Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Tree): apply custom focus style on TreeTitle and TreeItem #1506

Merged
merged 6 commits into from
Jun 18, 2019

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Jun 17, 2019

If focus is on TreeItem (<li>), style its TreeTitle instead.
Focus style is now the one from getBorderFocusStyles.

Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls address single comment, looks good 👍

padding: `${pxToRem(1)} 0`,
cursor: 'pointer',
color: variables.defaultColor,
border: `${pxToRem(2)} transparent solid`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cruft:)

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #1506 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1506   +/-   ##
======================================
  Coverage    73.2%   73.2%           
======================================
  Files         823     823           
  Lines        6221    6221           
  Branches     1786    1805   +19     
======================================
  Hits         4554    4554           
  Misses       1662    1662           
  Partials        5       5
Impacted Files Coverage Δ
...src/themes/teams/components/Tree/treeItemStyles.ts 50% <0%> (ø) ⬆️
...rc/themes/teams/components/Tree/treeTitleStyles.ts 50% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2761231...aa374da. Read the comment docs.

@silviuaavram silviuaavram merged commit 4660415 into master Jun 18, 2019
@silviuaavram silviuaavram deleted the fix/tree-item-focus-style branch June 18, 2019 09:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants