Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Toolbar): Add ARIA attributes and focus handling for radio group #1526

Merged
merged 20 commits into from
Jun 27, 2019
Merged

feat(Toolbar): Add ARIA attributes and focus handling for radio group #1526

merged 20 commits into from
Jun 27, 2019

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Jun 21, 2019 •
edited

closes #1470

@sophieH29 sophieH29 added ⚙️ enhancement New feature or request 🚧 WIP accessibility All the Accessibility tasks and bugs should be tagged with this. labels Jun 21, 2019
@sophieH29 sophieH29 self-assigned this Jun 21, 2019
@sophieH29 sophieH29 changed the title [WIP] feat(Toolbar): Add ARIA attributes and focus handling for radio group feat(Toolbar): Add ARIA attributes and focus handling for radio group Jun 23, 2019
bmdalex
bmdalex approved these changes Jun 25, 2019
View reviewed changes
Copy link
Collaborator

@bmdalex bmdalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job 👍

Sofiya Huts added 4 commits June 27, 2019 11:41
Merge branch 'master' into feat/a11y-radiogroup-in-toolbar
059eb7f 
# Conflicts:
#	docs/src/examples/components/Toolbar/Types/ToolbarExampleEditor.shorthand.tsx
#	docs/src/examples/components/Toolbar/Types/index.tsx
#	packages/react/src/components/Toolbar/ToolbarRadioGroup.tsx
update changelog
fe078e4
small improvement
8a47a62
fix tests
b2abfd4
@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited

Codecov Report

Merging #1526 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
+ Coverage    71.6%   71.72%   +0.12%     
==========================================
  Files         835      837       +2     
  Lines        6789     6818      +29     
  Branches     1946     1933      -13     
==========================================
+ Hits         4861     4890      +29     
  Misses       1922     1922              
  Partials        6        6
Impacted Files Coverage Δ
...ity/Behaviors/Toolbar/toolbarRadioGroupBehavior.ts 100% <100%> (ø)
...Behaviors/Toolbar/toolbarRadioGroupItemBehavior.ts 100% <100%> (ø)
...react/src/components/Toolbar/ToolbarRadioGroup.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9146b5e...c5c029f. Read the comment docs.

@sophieH29 sophieH29 merged commit d169600 into master Jun 27, 2019
@sophieH29 sophieH29 deleted the feat/a11y-radiogroup-in-toolbar branch June 27, 2019 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmdalex bmdalex bmdalex approved these changes

@miroslavstastny miroslavstastny miroslavstastny approved these changes

@jurokapsiar jurokapsiar jurokapsiar approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@sophieH29 sophieH29

Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. ⚙️ enhancement New feature or request 🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radio group in Toolbar
4 participants
@sophieH29 @bmdalex @miroslavstastny @jurokapsiar