feat(Icon): add alert, info, share-alt and microsoft-stream icons to Teams theme
#1544
Conversation
marst89
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
icons added
|
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
+ Coverage 71.55% 71.56% +0.01%
==========================================
Files 838 842 +4
Lines 6858 6862 +4
Branches 1947 1947
==========================================
+ Hits 4907 4911 +4
Misses 1945 1945
Partials 6 6
Continue to review full report at Codecov.
|
|
|
||
| export default { | ||
| icon: ({ classes }) => ( | ||
| <svg role="presentation" focusable="false" className={classes.svg} viewBox="8 8 16 16"> |
There was a problem hiding this comment.
@codepretty This icon is always outline, never filled:
Is it ok?
There was a problem hiding this comment.
For my case is fine. Also, for this particular one I just exported this from the processed ones. I did not create this from scratch.
There was a problem hiding this comment.
Here is the filled path
<path class="filled" d="M23.7,20L17.6,9.7c-0.1-0.2-0.3-0.4-0.5-0.5C16.9,9.1,16.7,9,16.4,9c-0.2,0-0.5,0.1-0.7,0.2c-0.2,0.1-0.4,0.3-0.5,0.5 L9.2,20C9.1,20.2,9,20.4,9,20.7c0,0.4,0.1,0.7,0.4,1c0.3,0.3,0.6,0.4,1,0.4h12.1c0.4,0,0.7-0.1,1-0.4c0.3-0.3,0.4-0.6,0.4-1 C23.9,20.4,23.8,20.2,23.7,20z M16,12.6c0-0.3,0.2-0.5,0.5-0.5s0.5,0.2,0.5,0.5v4.7c0,0.3-0.2,0.5-0.5,0.5S16,17.6,16,17.3V12.6z M16.5,20.8c-0.4,0-0.8-0.3-0.8-0.8c0-0.4,0.3-0.8,0.8-0.8s0.8,0.3,0.8,0.8C17.3,20.4,16.9,20.8,16.5,20.8z"></path>
| @@ -3,6 +3,7 @@ import { TeamsSvgIconSpec } from '../types' | |||
| import accept from './accept' | |||
| import add from './add' | |||
| import addParticipant from './addParticipant' | |||
| import alert from './alert' | |||
There was a problem hiding this comment.
I would rename to exclamation-triangle
| @@ -244,6 +250,7 @@ export default { | |||
| search, | |||
| send, | |||
| settings, | |||
| 'share-recording': shareRecording, | |||
There was a problem hiding this comment.
share-recording is too specific for this icon, i would suggest naming it more generically like share or share-alt as font awesome does
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-call-alert.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Icon/svg/ProcessedIcons/icons-msft-stream.tsx
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
…poutac/add-missing-icons
layershifter
changed the title
alert, info, share-alt and microsoft-stream icons to Teams theme
Add
alert,info,share-altandmicrosoft-streamicons to Teams theme.