This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popup): update styles for popup colors in Teams themes #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
+ Coverage 71.67% 71.68% +0.01%
==========================================
Files 848 847 -1
Lines 6916 6915 -1
Branches 1985 1965 -20
==========================================
Hits 4957 4957
+ Misses 1953 1952 -1
Partials 6 6
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Jul 1, 2019
notandrew
reviewed
Jul 8, 2019
| @@ -13,9 +16,12 @@ export interface PopupContentVariables { | |||
|
|
|||
| export default (siteVars: any): PopupContentVariables => { | |||
| return { | |||
| borderColor: siteVars.colors.grey[250], | |||
| borderColor: siteVars.colorScheme.default.border2, | |||
| borderRadius: pxToRem(3), | |||
There was a problem hiding this comment.
Should this be an explicit value instead of rems because of the border being 1px always?
notandrew
approved these changes
Jul 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the box shadow and border colors for popup in Teams theme
Teams theme
Teams-dark theme
Teams-high-contrast theme
