Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(createComponent): add static className prop #1563

Merged
merged 8 commits into from
Jul 3, 2019

Conversation

kuzhelov
Copy link
Contributor

@kuzhelov kuzhelov commented Jul 1, 2019

Fixes #1545 .

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #1563 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1563      +/-   ##
==========================================
+ Coverage   71.63%   71.68%   +0.04%     
==========================================
  Files         848      848              
  Lines        6910     6911       +1     
  Branches     1961     1961              
==========================================
+ Hits         4950     4954       +4     
+ Misses       1954     1951       -3     
  Partials        6        6
Impacted Files Coverage Δ
packages/react/src/lib/createComponent.tsx 94.44% <100%> (+6.2%) ⬆️
packages/react/src/lib/createStardustComponent.tsx 50% <100%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e312aa7...1b54570. Read the comment docs.

@kuzhelov kuzhelov merged commit 552bd70 into master Jul 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/create-component-class-name branch July 3, 2019 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Component missing className
4 participants