This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): fix Dropdown ArrowLeft keydown behavior for multiple variants #1564
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1129
It was broken when the user was (shift-)tabbing from the last selected item. If the last item was already marked as active, then ArrowLeft from SearchInput would not re-focus it, due to the logic in
DropdownSelectedItem
:if (!prevProps.active && this.props.active) {
I don't like the solution chosen but I cannot think of anything else less intrusive than this.