This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: refactored highlightedIndex on Arrow keydown #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initiate
highlightedIndex
on ArrowUp and ArrowDown open.Refactored how the index is calculated.
If user passes anything related to highlightedIndex, then we don't change its value on open, even on Arrow Up/Down. This includes controlled
highlightedIndex
,defaultHighlightedIndex
orhighlightFirstItemOnOpen
.Fixes #1176
Avoided major refactoring in this area as I want to use hooks in the future rather than have this logic here anymore.