This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(CodeSnippet): fixing issue with copy icon taking up entire page #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notandrew
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 846 846
Lines 6893 6893
Branches 1960 1960
=======================================
Hits 4939 4939
Misses 1948 1948
Partials 6 6Continue to review full report at Codecov.
|
|
Can we fix this also for IE11?
|
layershifter
reviewed
Jul 3, 2019
| @@ -36,8 +36,7 @@ const CodeSnippetLabel: React.FunctionComponent<CopySnippetLabelProps> = props = | |||
| border: '1px solid #ccc', | |||
| color: '#ccc', | |||
| cursor: copyable ? 'pointer' : 'default', | |||
| display: 'grid', | |||
| gridTemplateColumns: 'auto auto', | |||
| display: 'flex', | |||
There was a problem hiding this comment.
grid is not working in IE11
layershifter
reviewed
Jul 3, 2019
| @@ -17,7 +17,7 @@ const checkIcon = ( | |||
| ) | |||
|
|
|||
| const copyIcon = ( | |||
| <svg height="0.7rem" viewBox="0 0 16 16"> | |||
| <svg style={{ height: '.7rem', width: '0.7rem' }} viewBox="0 0 16 16"> | |||
There was a problem hiding this comment.
width should be also fixed for IE11
Chrome
IE11
Firefox
|
layershifter
approved these changes
Jul 3, 2019
layershifter
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing height property from copy icon SVG and replacing with style. Firefox ignored the height property and displayed the icon at full window size.
Before:
after:
