This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Checkbox): add labelPosition prop
#1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
mnajdova
reviewed
Jul 3, 2019
| @@ -17,6 +17,10 @@ const checkboxStyles: ComponentSlotStylesInput<CheckboxProps & CheckboxState, Ch | |||
| color: v.disabledColor, | |||
| cursor: 'default', | |||
| }), | |||
|
|
|||
| '> *:not(:last-child)': { | |||
There was a problem hiding this comment.
Not sure about this selector. Do we really need this complication?
mnajdova
approved these changes
Jul 3, 2019
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
- Coverage 71.68% 71.67% -0.01%
==========================================
Files 848 848
Lines 6911 6916 +5
Branches 1981 1984 +3
==========================================
+ Hits 4954 4957 +3
- Misses 1951 1953 +2
Partials 6 6
Continue to review full report at Codecov.
|
…om/stardust-ui/react into feat/checkbox-label
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535.
labelPosition={start|end}This PR adds a new
labelPositionprop. Styles for a gap betweenlabelandiconwas inspired byFlexcomponent.Docs refactor
Disabledexample was moved toStatessectionCheckedstate