This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(Layout): update documentation page #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
commented
Jul 8, 2019
| const ExampleSnippet = ({ render = () => null, value }: ExampleSnippetProps) => { | ||
| const element = render() | ||
| const string = value || renderElementToJSX(element, !value) | ||
| const ExampleSnippet: React.FunctionComponent<ExampleSnippetProps> = props => { |
There was a problem hiding this comment.
Component was updated to support passing child element:
<ExampleSnippet>
<Flex gap="gap.small">
<Button content="Accept" />
<Button content="Deny" />
</Flex>
</ExampleSnippet>
Codecov Report
@@ Coverage Diff @@
## master #1595 +/- ##
=======================================
Coverage 71.53% 71.53%
=======================================
Files 848 848
Lines 6932 6932
Branches 1977 1977
=======================================
Hits 4959 4959
Misses 1967 1967
Partials 6 6Continue to review full report at Codecov.
|
lucivpav
reviewed
Jul 8, 2019
lucivpav
reviewed
Jul 8, 2019
Co-Authored-By: Pavel Lučivňák <pavel.lucivnak@gmail.com>
Co-Authored-By: Pavel Lučivňák <pavel.lucivnak@gmail.com>
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://stardust-react-git-docs-layout.stardust-ui.now.sh |
alinais
approved these changes
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates of
Layoutguide:SegmentandBoxwas removed completelyFlex Recipeswere move toFlexdocs