This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(types): make Props param in ShorthandValue and ShorthandCollection required #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1605 +/- ##
==========================================
+ Coverage 71.23% 71.24% +0.01%
==========================================
Files 851 851
Lines 7032 7035 +3
Branches 2025 2027 +2
==========================================
+ Hits 5009 5012 +3
Misses 2017 2017
Partials 6 6
Continue to review full report at Codecov.
|
…/stardust-ui/react into chore/type-script # Conflicts: # docs/src/prototypes/chatMessages/MessageReactionsWithPopup/index.tsx # packages/react/src/components/Button/ButtonGroup.tsx # packages/react/src/components/Dialog/Dialog.tsx # packages/react/src/components/Dropdown/Dropdown.tsx # packages/react/src/components/Form/Form.tsx # packages/react/src/components/Input/Input.tsx # packages/react/src/components/Reaction/ReactionGroup.tsx # packages/react/src/lib/factories.ts # packages/react/test/specs/lib/factories-test.tsx
mnajdova
reviewed
Jul 15, 2019
docs/src/examples/components/Chat/Content/ChatExampleReactionGroupMeReacting.shorthand.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jul 15, 2019
|
|
||
| /** Indicates whether the content is positioned at the start or the end. */ | ||
| contentPosition?: 'start' | 'end' | ||
|
|
||
| /** Chat items can have a message. */ | ||
| message?: ShorthandValue | ||
| message?: ShorthandValue<ChatMessageProps> |
There was a problem hiding this comment.
Actually this should be BoxProps, see line 109. We can easily do some miss match here.. :(
There was a problem hiding this comment.
Great catch 👍
I am bit disappointed that we don't have strict checks there, but at least we will be able to improve them and catch such cases
…ore/type-script # Conflicts: # docs/src/components/Sidebar/Sidebar.tsx
mnajdova
reviewed
Jul 15, 2019
packages/react/src/components/Dropdown/DropdownSelectedItem.tsx
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jul 15, 2019
mnajdova
reviewed
Jul 15, 2019
…/stardust-ui/react into chore/type-script
mnajdova
reviewed
Jul 15, 2019
mnajdova
approved these changes
Jul 15, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Only if you have used
ShorthandValueorShorthandCollectiontypes.Before
After
This PR makers
PinShorthandValue<P>required, this will allow to get better autocomplete, improve types and generate better prop definitions.