-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
==========================================
- Coverage 71.48% 71.46% -0.03%
==========================================
Files 845 845
Lines 6943 6945 +2
Branches 1980 1981 +1
==========================================
Hits 4963 4963
- Misses 1974 1976 +2
Partials 6 6
Continue to review full report at Codecov.
|
docs/src/examples/components/Dialog/Content/DialogExampleContent.shorthand.tsx
Outdated
Show resolved
Hide resolved
@sophieH29 let's discuss - we might do something like looking for the focusable in content first and then in the header actions if we did not find anything @mnajdova yes, the focus indicator should be there - I will leave it up to you if you want to add it in this PR or if you want to create an issue - it probably also depends on if you have the red lines or not. |
-changed focus styles for the text buttons
…st-ui/react into feat/dialog-add-icon-slot
@@ -148,6 +148,12 @@ const buttonStyles: ComponentSlotStylesInput<ButtonProps & ButtonState, ButtonVa | |||
color: textPrimaryColorHover, | |||
}, | |||
}), | |||
|
|||
':focus': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added focus styles for the text button
docs/src/examples/components/Dialog/Content/DialogExampleContent.shorthand.tsx
Outdated
Show resolved
Hide resolved
-improved typings for the shorthand value props in the Dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment
docs/src/examples/components/Dialog/Content/DialogExampleHeaderAction.shorthand.tsx
Show resolved
Hide resolved
…ader action examples
@miroslavstastny I thought about the same thing, so I added steps for the Dialog - the new example and the example with the content... In a separate pr we can add more examples for the popups and tooltips. |
This PR adds a
headerAction
to theDialog
component. This button istext
andiconOnly
and is rendered after theheader
slot. I noticed that it is the first thing focused when theDialog
is opened (not sure if this is the behavior we want) @jurokapsiar @sophieH29 please share your thoughts on this. Also the focus indicator is not implemented for thetextOnly
variant for the button. I may add that as part of this PR.