This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): Add image-unavailable icon to Teams Theme #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheredi
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
alinais
reviewed
Jul 16, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/image-unavailable.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
+ Coverage 71.28% 71.29% +<.01%
==========================================
Files 853 854 +1
Lines 7046 7047 +1
Branches 2008 2029 +21
==========================================
+ Hits 5023 5024 +1
Misses 2017 2017
Partials 6 6
Continue to review full report at Codecov.
|
notandrew
reviewed
Jul 16, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/image-unavailable.tsx
Outdated
Show resolved
Hide resolved
notandrew
suggested changes
Jul 16, 2019
packages/react/src/themes/teams/components/Icon/svg/icons/image-unavailable.tsx
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
packages/react/src/themes/teams/components/Icon/svg/icons/index.ts
Outdated
Show resolved
Hide resolved
…-icons-image-unavailable
…ust-ui/react into feat/teams-icons-image-unavailable
joheredi
changed the title
alinais
approved these changes
Jul 18, 2019
notandrew
approved these changes
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding image-unavailable icon to Teams Theme
