Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(ChatMessage): chat message focus is overlaying message actions in Teams theme #1637

Merged
merged 5 commits into from
Jul 15, 2019
Merged

fix(ChatMessage): chat message focus is overlaying message actions in Teams theme #1637

merged 5 commits into from
Jul 15, 2019

Conversation

mnajdova
Copy link
Contributor

@mnajdova mnajdova commented Jul 15, 2019 •
edited

Fixes #1609

Before:
image

After:
image

@mnajdova mnajdova changed the title fix(ChatMessage): chat message focus is overlaying message actions in Teams theme [WIP] fix(ChatMessage): chat message focus is overlaying message actions in Teams theme Jul 15, 2019
@codecov
Copy link

codecov bot commented Jul 15, 2019 •
edited

Codecov Report

Merging #1637 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1637   +/-   ##
=======================================
  Coverage   71.23%   71.23%           
=======================================
  Files         851      851           
  Lines        7032     7032           
  Branches     2025     2025           
=======================================
  Hits         5009     5009           
  Misses       2017     2017           
  Partials        6        6
Impacted Files Coverage Δ
.../themes/teams/components/Chat/chatMessageStyles.ts 2.32% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027e269...95b471b. Read the comment docs.

@mnajdova mnajdova changed the title [WIP] fix(ChatMessage): chat message focus is overlaying message actions in Teams theme fix(ChatMessage): chat message focus is overlaying message actions in Teams theme Jul 15, 2019
@mnajdova mnajdova added 🚀 ready for review 🧰 fix Introduces fix for broken behavior. labels Jul 15, 2019
@mnajdova mnajdova merged commit 424ba3c into master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/action-menu-cut-off-teams-theme branch July 15, 2019 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmdalex bmdalex bmdalex approved these changes

@kuzhelov kuzhelov kuzhelov approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

Assignees
No one assigned
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chat message focus is overlaying message actions
3 participants
@mnajdova @bmdalex @kuzhelov