Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(docs): add search capability #1682

Merged
merged 34 commits into from
Aug 1, 2019
Merged

feat(docs): add search capability #1682

merged 34 commits into from
Aug 1, 2019

Conversation

lucivpav
Copy link
Contributor

@lucivpav lucivpav commented Jul 18, 2019

This PR adds a search input to the top part of sidebar. The search goes through all the below tree's sections, effectively filtering those that match the query. The items are matched in case-insensitive fashion.

search

As you can see, the icon is not rendered at an expected position. This looks like a bug in Input component, reported here.

The search input is not fully accessible - it does not let the user know, how many items were found (matching the query). This would be solved in a future PR.

You can search by typing even when the element is not focused (provided no other input element is in focus).

@codecov
Copy link

codecov bot commented Jul 18, 2019

Codecov Report

Merging #1682 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1682   +/-   ##
=======================================
  Coverage   71.06%   71.06%           
=======================================
  Files         862      862           
  Lines        7172     7172           
  Branches     2082     2082           
=======================================
  Hits         5097     5097           
  Misses       2069     2069           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a49f1f...405cdd5. Read the comment docs.

@vercel vercel bot temporarily deployed to staging July 18, 2019 15:10 Inactive
@lucivpav
Copy link
Contributor Author

Problem: category of currently selected section cannot be collapsed anymore.

@lucivpav
Copy link
Contributor Author

Problem: category of currently selected section cannot be collapsed anymore.

Fixed.

@lucivpav
Copy link
Contributor Author

Icon's location has been fixed by manually setting the icon's padding.

image

@mnajdova
Copy link
Contributor

I would expect that Concepts, Guides and Prototypes would not be visible in this case
image

@vercel vercel bot temporarily deployed to staging July 29, 2019 15:19 Inactive
@vercel vercel bot temporarily deployed to staging July 31, 2019 16:29 Inactive
@vercel vercel bot temporarily deployed to staging July 31, 2019 16:55 Inactive
@vercel vercel bot temporarily deployed to staging July 31, 2019 16:56 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants