This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(Popup): fix broken background with pointing and FocusTrap #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## chore/0.34.2 #1689 +/- ##
================================================
- Coverage 71.43% 71.42% -0.02%
================================================
Files 848 848
Lines 6942 6943 +1
Branches 2007 1988 -19
================================================
Hits 4959 4959
- Misses 1977 1978 +1
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
July 19, 2019 13:27
kuzhelov
reviewed
Jul 19, 2019
/* | ||
* This fix handles all cases with wrapped focus trap. | ||
*/ | ||
...(React.isValidElement(p.content) && { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, this should also apply in case if render function is provided as an argument :( as in that case slot component will be also replaced. So, I think that we may just check that this is not an object or primitive
kuzhelov
approved these changes
Jul 19, 2019
Adjusted to handle <Popup open trigger={<Button icon="expand"/>} content={render => render(
{},
(ComponentType, props) => (
<p style={{ zIndex: 1000, padding: 5 }}>Plain popup content rendered 'as is'.</p>
),
)}/>
<Popup open trigger={<Button icon="expand"/>} pointing content={render => render(
{},
(ComponentType, props) => (
<div {...props} style={{ zIndex: 1000, padding: 5}}>
Plain popup content rendered 'as is'.
</div>
),
)}/> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1679.
Problem
In
master
we have already resolved this issue by #1565, however we need to provide a fix without breaking changes for now.Before
After
Test snippet