This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Icon): make "name" prop required #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1723 +/- ##
=======================================
Coverage 70.98% 70.98%
=======================================
Files 860 860
Lines 7156 7156
Branches 2058 2078 +20
=======================================
Hits 5080 5080
Misses 2070 2070
Partials 6 6
Continue to review full report at Codecov.
|
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
layershifter
approved these changes
Jul 26, 2019
mnajdova
reviewed
Jul 26, 2019
|
@layershifter can you please take a look at the new changes? I have fixed the test errors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An instantiated
Iconwithout anamemakes no sense. This PR makes thenameprop mandatory. An alternative would be to set a default name value. This resolves issue #1715.