This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
chore(List): use FocusZone in selectable list #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurokapsiar
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
|
TODO: changelog |
sophieH29
reviewed
Aug 5, 2019
packages/react/src/lib/accessibility/Behaviors/List/selectableListBehavior.ts
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #1757 +/- ##
==========================================
- Coverage 70% 69.99% -0.01%
==========================================
Files 868 868
Lines 7351 7323 -28
Branches 2144 2140 -4
==========================================
- Hits 5146 5126 -20
+ Misses 2199 2191 -8
Partials 6 6
Continue to review full report at Codecov.
|
sophieH29
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FocusZone for selectable list instead of the FocusHandler. This will allow us to use focus restoration on item removed once the appropriate change from fabric gets merged. It is also much more performant as the List does not have to update state on each keypress.