This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
fix(embed): make component focusable, only show control/placeholder on video #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
August 5, 2019 09:58
Codecov Report
@@ Coverage Diff @@
## master #1758 +/- ##
==========================================
+ Coverage 69.77% 69.78% +0.01%
==========================================
Files 870 870
Lines 7486 7496 +10
Branches 2176 2204 +28
==========================================
+ Hits 5223 5231 +8
- Misses 2255 2257 +2
Partials 8 8
Continue to review full report at Codecov.
|
This reverts commit 7b13cf2.
This pull request is automatically deployed with Now. Latest deployment for this branch: https://stardust-react-git-fix-embed-focus.stardust-ui.now.sh |
sophieH29
approved these changes
Aug 6, 2019
alinais
approved these changes
Aug 6, 2019
@alinais please review this PR again, it has changed quite a bit since last time |
alinais
approved these changes
Aug 12, 2019
miroslavstastny
suggested changes
Aug 12, 2019
packages/react/src/themes/teams/components/Embed/embedVariables.ts
Outdated
Show resolved
Hide resolved
miroslavstastny
approved these changes
Aug 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1767, which states that:
This PR also resolves issue #1742 by making the
Embed
component focusable using keyboard.Other changes
control button, placeholder is not shown whenvideo
prop not setbackground set tocolorScheme.brand.background
TODO