This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(FocusZone): Upgrade to the latest version #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2019 16:20
sophieH29
added
⚙️ enhancement
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
=========================================
+ Coverage 69.77% 70.07% +0.3%
=========================================
Files 867 867
Lines 7354 7429 +75
Branches 2159 2161 +2
=========================================
+ Hits 5131 5206 +75
Misses 2215 2215
Partials 8 8
Continue to review full report at Codecov.
|
lucivpav
reviewed
Aug 9, 2019
|
Please also update CHANGELOG |
jurokapsiar
approved these changes
Aug 12, 2019
| @@ -26,6 +26,12 @@ This is a list of changes made to this Stardust copy of FocusZone in comparison | |||
| - Handle keyDownCapture based on `shouldHandleKeyDownCapture` prop @sophieH29 ([#563](https://github.com/stardust-ui/react/pull/563)) | |||
| - Add `bidirectionalDomOrder` direction allowing arrow keys navigation following DOM order @sophieH29 ([#1637](https://github.com/stardust-ui/react/pull/1647)) | |||
|
|
|||
| ### Upgrade `FocusZone` to the latest version from `fabric-ui` @sophieH29 ([#1772](https://github.com/stardust-ui/react/pull/1772)) | |||
| - Restore focus on removing item ([OfficeDev/office-ui-fabric-react#7818](https://github.com/OfficeDev/office-ui-fabric-react/pull/7818)) | |||
There was a problem hiding this comment.
I don't see any UTs added for 7818.
There was a problem hiding this comment.
| ### Upgrade `FocusZone` to the latest version from `fabric-ui` @sophieH29 ([#1772](https://github.com/stardust-ui/react/pull/1772)) | ||
| - Restore focus on removing item ([OfficeDev/office-ui-fabric-react#7818](https://github.com/OfficeDev/office-ui-fabric-react/pull/7818)) | ||
| - Reduce global event listeners ([OfficeDev/office-ui-fabric-react#7958](https://github.com/OfficeDev/office-ui-fabric-react/pull/7958)) | ||
| - Track innerzones correctly ([OfficeDev/office-ui-fabric-react#8560](https://github.com/OfficeDev/office-ui-fabric-react/pull/8560)) |
There was a problem hiding this comment.
I didn't like an idea to add a public static method to FZ API to test it as here https://github.com/OfficeDev/office-ui-fabric-react/pull/8560/files#diff-2949b523d6a4d1f7e2e111abb6557158R82
If you're ok with that, I'll add it
miroslavstastny
approved these changes
Aug 12, 2019
delete-merged-branch
bot
deleted the
feat/upgrade-focus-zone-and-trap-zone
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
FocusZoneto the latest version fromfabric-uilibrary.Changes made based on these PRs: