Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(FocusTrapZone): upgrade to the latest version from fabric-ui #1790

Merged
merged 12 commits into from
Aug 19, 2019

Conversation

sophieH29
Copy link
Contributor

@sophieH29 sophieH29 commented Aug 13, 2019

This PR aims to upgrade FocusTrapZone to the latest version as in fabric-ui.
Next PRs were applied:

@sophieH29 sophieH29 added ⚙️ enhancement New feature or request 🚀 ready for review accessibility All the Accessibility tasks and bugs should be tagged with this. labels Aug 13, 2019
@sophieH29 sophieH29 self-assigned this Aug 13, 2019
@sophieH29 sophieH29 changed the title feat(FocusTrapZone): upgrade to the latest package of fabric-ui feat(FocusTrapZone): upgrade to the latest version from fabric-ui Aug 13, 2019
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #1790 into master will decrease coverage by 0.06%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1790      +/-   ##
==========================================
- Coverage   69.63%   69.57%   -0.07%     
==========================================
  Files         875      875              
  Lines        7534     7588      +54     
  Branches     2220     2248      +28     
==========================================
+ Hits         5246     5279      +33     
- Misses       2280     2301      +21     
  Partials        8        8
Impacted Files Coverage Δ
.../src/lib/accessibility/FocusZone/focusUtilities.ts 87.75% <100%> (-5.45%) ⬇️
.../src/lib/accessibility/FocusZone/FocusTrapZone.tsx 72.1% <81.05%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a8864a...c0c17fc. Read the comment docs.

@sophieH29 sophieH29 merged commit 7bb30c6 into master Aug 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/upgrade-focus-trap-zone branch August 19, 2019 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility All the Accessibility tasks and bugs should be tagged with this. ⚙️ enhancement New feature or request 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants