This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Icon): add 'window-maximize' 'window-minimize' and 'window-restore' icons #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codepretty
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
=========================================
Coverage ? 69.79%
=========================================
Files ? 876
Lines ? 7506
Branches ? 2208
=========================================
Hits ? 5239
Misses ? 2259
Partials ? 8
Continue to review full report at Codecov.
|
layershifter
approved these changes
Aug 16, 2019
CHANGELOG.md
Outdated
| @@ -31,6 +31,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Add possibility for a Toolbar to rearrange its items according to space available @miroslavstastny ([#1657](https://github.com/stardust-ui/react/pull/1657)) | |||
| - Edit `buttonBehavior` Adding aria-disabled when button has loading state @kolaps33 ([#1789](https://github.com/stardust-ui/react/pull/1789)) | |||
| - Added `audio-off` and `clipboard-copied-to` icon to Teams theme @bcalvery ([#1792](https://github.com/stardust-ui/react/pull/1792)) | |||
| - Added `window-maximize`, `window-minimize` and `window-unmaximize` icons to Teams theme @codepretty ([#1803](https://github.com/stardust-ui/react/pull/1803)) | |||
There was a problem hiding this comment.
What about window-restore? As in FontAwesome:
There was a problem hiding this comment.
Good find! I didn't notice those, so wasn't sure what to use for "unmaximize". Will update that to window-restore
layershifter
added
⚙️ enhancement
codepretty
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 new icons to Teams theme.
window-maximizewindow-minimizeandwindow-restore