This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/transfer-target
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
August 16, 2019 14:24
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
==========================================
+ Coverage 69.76% 69.77% +0.01%
==========================================
Files 875 875
Lines 7505 7508 +3
Branches 2182 2182
==========================================
+ Hits 5236 5239 +3
Misses 2261 2261
Partials 8 8
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Aug 16, 2019
….com/stardust-ui/react into chore/transfer-target # Conflicts: # CHANGELOG.md
….com/stardust-ui/react into chore/transfer-target # Conflicts: # CHANGELOG.md
layershifter
added a commit
that referenced
this pull request
Aug 19, 2019
* fix(Provider): use `target` in context * wipwip * wipwipwip * fix UT * remove default props * remove one more default prop * add changelog entry * fixfixfix (cherry picked from commit 11e0ba4)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ❓
In #1252 we introduced ability to use specify
target
prop onProvider
to specify where styles should be rendered. But as we discovered then, it's not enough. See CodeSandbox, for the issue: https://codesandbox.io/s/stardust-ui-example-6quzy?from-embedFix 🛠
Add
target
as a part of existingcontext
.Why use existing?
All of our components are class component and they can consume only single context without using
Context.Consumer
.