Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(Provider): use target in context #1810

Merged
merged 12 commits into from
Aug 19, 2019
Merged

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 16, 2019

Why ❓

In #1252 we introduced ability to use specify target prop on Provider to specify where styles should be rendered. But as we discovered then, it's not enough. See CodeSandbox, for the issue: https://codesandbox.io/s/stardust-ui-example-6quzy?from-embed

Fix 🛠

Add target as a part of existing context.

Why use existing?

All of our components are class component and they can consume only single context without using Context.Consumer.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #1810 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
+ Coverage   69.76%   69.77%   +0.01%     
==========================================
  Files         875      875              
  Lines        7505     7508       +3     
  Branches     2182     2182              
==========================================
+ Hits         5236     5239       +3     
  Misses       2261     2261              
  Partials        8        8
Impacted Files Coverage Δ
packages/react/src/types.ts 50% <ø> (ø) ⬆️
packages/react/src/components/Tooltip/Tooltip.tsx 60.86% <ø> (-1.11%) ⬇️
...ackages/react/src/components/Provider/Provider.tsx 95.45% <ø> (ø) ⬆️
...ckages/react/src/components/Portal/PortalInner.tsx 100% <100%> (ø) ⬆️
packages/react/test/utils/withProvider.tsx 100% <100%> (ø) ⬆️
...kages/react/src/components/Toolbar/ToolbarItem.tsx 48.21% <100%> (+0.94%) ⬆️
packages/react/src/lib/mergeProviderContexts.ts 100% <100%> (ø) ⬆️
packages/react/src/components/Dialog/Dialog.tsx 36.36% <100%> (+1.47%) ⬆️
packages/react/src/components/Popup/Popup.tsx 65.51% <100%> (-0.2%) ⬇️
packages/react/src/components/Menu/MenuItem.tsx 34.73% <100%> (+0.69%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706cddd...4152ae9. Read the comment docs.

@vercel vercel bot temporarily deployed to staging August 16, 2019 14:51 Inactive
@layershifter layershifter added 🧰 fix Introduces fix for broken behavior. 🚀 ready for review labels Aug 19, 2019
@vercel vercel bot temporarily deployed to staging August 19, 2019 08:41 Inactive
@layershifter layershifter merged commit 11e0ba4 into master Aug 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/transfer-target branch August 19, 2019 09:31
layershifter added a commit that referenced this pull request Aug 19, 2019
* fix(Provider): use `target` in context

* wipwip

* wipwipwip

* fix UT

* remove default props

* remove one more default prop

* add changelog entry

* fixfixfix

(cherry picked from commit 11e0ba4)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 fix Introduces fix for broken behavior. 🚀 ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants