This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Tooltip): Fixing incorrect tooltip shadow #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
+ Coverage 69.56% 69.57% +<.01%
==========================================
Files 875 874 -1
Lines 7596 7595 -1
Branches 2219 2219
==========================================
Hits 5284 5284
+ Misses 2304 2303 -1
Partials 8 8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
==========================================
+ Coverage 69.49% 69.51% +0.01%
==========================================
Files 875 874 -1
Lines 7602 7603 +1
Branches 2214 2214
==========================================
+ Hits 5283 5285 +2
+ Misses 2311 2310 -1
Partials 8 8
Continue to review full report at Codecov.
|
…x/tooltip-shadow-darktheme
…x/tooltip-shadow-darktheme
codepretty
reviewed
Aug 20, 2019
CHANGELOG.md
Outdated
| @@ -31,6 +31,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Fix `hand` icon in Teams theme @lucivpav ([#1782](https://github.com/stardust-ui/react/pull/1782)) | |||
| - ESC key should close the last opened `Popup` or `Dialog` if body has focus @sophieH29 ([#1807](https://github.com/stardust-ui/react/pull/1807)) | |||
| - Correctly define current document object of the `FocusZone` and `FocusTrapZone` @sophieH29 ([#1820](https://github.com/stardust-ui/react/pull/1820)) | |||
| - Fix `Tooltip` shadow incorrect [redlines] @bcalvery ([#1825](https://github.com/stardust-ui/react/pull/1825)) | |||
There was a problem hiding this comment.
@miroslavstastny, does a variable rename need to be in the BREAKING CHANGES section?
There was a problem hiding this comment.
@codepretty yep, as it's a part of public API
codepretty
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed TooltipContentVariables to use shadow value defined in siteVariables rather than separate values defined within tooltip.
Before:
After: