-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
+ Coverage 69.56% 69.56% +<.01%
==========================================
Files 875 875
Lines 7596 7606 +10
Branches 2219 2227 +8
==========================================
+ Hits 5284 5291 +7
- Misses 2304 2307 +3
Partials 8 8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
==========================================
- Coverage 69.49% 69.49% -0.01%
==========================================
Files 875 875
Lines 7603 7605 +2
Branches 2243 2244 +1
==========================================
+ Hits 5284 5285 +1
- Misses 2311 2312 +1
Partials 8 8
Continue to review full report at Codecov.
|
packages/react/src/themes/base/components/Dialog/dialogStyles.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
=========================================
- Coverage 69.51% 69.5% -0.01%
=========================================
Files 874 874
Lines 7603 7605 +2
Branches 2214 2242 +28
=========================================
+ Hits 5285 5286 +1
- Misses 2310 2311 +1
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also add an RTL example
|
Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
This PR fixes the way
Dialog
is rendered in RTL mode.Dialog in LTR mode:
Dialog in RTL mode:
In IE11 RTL, the question mark is placed on the left side of the sentence. This is probably not a bug, as described here.