This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(CodeSandbox): improve example #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
commented
Aug 23, 2019
| @@ -28,7 +28,7 @@ const createExampleSourceCode = (file: Vinyl): ExampleSource => { | |||
| }) | |||
| const prettierResult = prettier.format(babelResult.code, { | |||
| ...prettierConfig, | |||
| parser: 'babylon', | |||
| parser: 'babel', | |||
There was a problem hiding this comment.
Oops, missed this one previously
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Generated by 馃毇 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1844 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 874 874
Lines 7612 7612
Branches 2216 2216
=======================================
Hits 5301 5301
Misses 2303 2303
Partials 8 8Continue to review full report at Codecov.
|
lucivpav
approved these changes
Aug 26, 2019
Co-Authored-By: Pavel Lu膷iv艌谩k <pavel.lucivnak@gmail.com>
Co-Authored-By: Pavel Lu膷iv艌谩k <pavel.lucivnak@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1812.
馃拝 New template
I created a new template and decided to create a new package
@stardust-ui/code-sandboxwith it. It simplifies a lot template maintenance. Previously we had two separate templates for TS & JS, they also where defined as plain strings, https://github.com/stardust-ui/react/pull/1844/files#diff-b716b1190843f6af732bfcdd7f589a71.Now we have single template, type-checks and all new CodeSandboxes can always use it 馃弾 We can also implement later more features, even integrate the variable editor 馃槑
馃搼 Updated issue templates
I updated
Bug_report.mdandFeature_request.mdto use new template instead of SUIR template. I also fixed links inSupport_question.md.