fix(Video): fix muted prop
#1847
Conversation
| } else { | ||
| this.videoRef.current.removeAttribute('muted') | ||
| } | ||
| this.videoRef.current.muted = !!this.props.muted |
There was a problem hiding this comment.
facebook/react#10389 (comment)
We should set muted directly, setAttribute only shows this attribute on DOM.
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 69.64% 69.64% +<.01%
==========================================
Files 874 874
Lines 7612 7610 -2
Branches 2216 2215 -1
==========================================
- Hits 5301 5300 -1
+ Misses 2303 2302 -1
Partials 8 8
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 69.64% 69.64% +<.01%
==========================================
Files 874 874
Lines 7612 7610 -2
Branches 2216 2215 -1
==========================================
- Hits 5301 5300 -1
+ Misses 2303 2302 -1
Partials 8 8
Continue to review full report at Codecov.
|
This PR fixes the
mutedprop onVideocomponent, now it works properly.Tested in Chrome, FF, Edge and IE11.