This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
docs(Dropdown): update docs regarding renderSelectedItem
#1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
August 27, 2019 14:36
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
- Coverage 69.74% 69.74% -0.01%
==========================================
Files 885 885
Lines 7787 7786 -1
Branches 2249 2248 -1
==========================================
- Hits 5431 5430 -1
Misses 2348 2348
Partials 8 8
Continue to review full report at Codecov.
|
@layershifter is this actually a bug? If the behavior on master is expected, then we should update the prop documentation (which doesn't make it clear the prop only works when |
Not, it's not a bug. |
layershifter
added
needs author feedback
Author's opinion is asked
and removed
🚀 ready for review
labels
Aug 30, 2019
…-ui/react into fix/dropdown-renderSelectedItem
layershifter
reviewed
Sep 2, 2019
layershifter
reviewed
Sep 2, 2019
packages/react/test/specs/components/Dropdown/Dropdown-test.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Sep 2, 2019
packages/react/test/specs/components/Dropdown/Dropdown-test.tsx
Outdated
Show resolved
Hide resolved
layershifter
approved these changes
Sep 2, 2019
lucivpav
changed the title
fix(Dropdown): renderSelectedItem prop doesn't get called
docs(Dropdown): update docs regarding Sep 3, 2019
renderSelectedItem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584