Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

docs(Dropdown): update docs regarding renderSelectedItem #1856

Merged
merged 11 commits into from
Sep 3, 2019

Conversation

lucivpav
Copy link
Contributor

Fixes #1584

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #1856 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1856      +/-   ##
==========================================
- Coverage   69.74%   69.74%   -0.01%     
==========================================
  Files         885      885              
  Lines        7787     7786       -1     
  Branches     2249     2248       -1     
==========================================
- Hits         5431     5430       -1     
  Misses       2348     2348              
  Partials        8        8
Impacted Files Coverage Δ
...ackages/react/src/components/Dropdown/Dropdown.tsx 88.04% <ø> (ø) ⬆️
packages/react/src/components/Popup/Popup.tsx 65.92% <0%> (-0.19%) ⬇️
packages/react/src/lib/doesNodeContainClick.tsx 100% <0%> (ø) ⬆️
packages/react/src/components/Dialog/Dialog.tsx 35.29% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f0555...df78ce4. Read the comment docs.

@lucivpav
Copy link
Contributor Author

@layershifter is this actually a bug? If the behavior on master is expected, then we should update the prop documentation (which doesn't make it clear the prop only works when multiple is used)
image

@layershifter
Copy link
Member

@layershifter is this actually a bug?

Not, it's not a bug. renderSelectItem should be applied to DropdownSelectedItem, so proper fix is to update prop description.

image

@layershifter layershifter added needs author feedback Author's opinion is asked and removed 🚀 ready for review labels Aug 30, 2019
@vercel vercel bot temporarily deployed to staging August 30, 2019 11:38 Inactive
@lucivpav lucivpav changed the title fix(Dropdown): renderSelectedItem prop doesn't get called docs(Dropdown): update docs regarding renderSelectedItem Sep 3, 2019
@lucivpav lucivpav merged commit f2478e2 into master Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/dropdown-renderSelectedItem branch September 3, 2019 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown's renderSelectedItem prop doesn't get called
2 participants