This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(doesNodeContainClick): use proper document to find nodes
#1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
document to find nodesdocument to find nodes
…x/does-node-contains # Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## master #1874 +/- ##
==========================================
+ Coverage 69.74% 69.74% +<.01%
==========================================
Files 885 885
Lines 7786 7787 +1
Branches 2274 2276 +2
==========================================
+ Hits 5430 5431 +1
Misses 2348 2348
Partials 8 8
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Sep 2, 2019
layershifter
added a commit
that referenced
this pull request
Sep 3, 2019
(cherry picked from commit 87f0555)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1873.
Also improved typings in
doesNodeContains().Before
After