Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

perf(Tooltip): fix Popper positioning called when unnecessary #1882

Merged
merged 5 commits into from
Sep 3, 2019
Merged

perf(Tooltip): fix Popper positioning called when unnecessary #1882

merged 5 commits into from
Sep 3, 2019

Conversation

lucivpav
Copy link
Contributor

@lucivpav lucivpav commented Sep 3, 2019

Fixes #1880

@codecov
Copy link

codecov bot commented Sep 3, 2019 •
edited

Codecov Report

Merging #1882 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1882      +/-   ##
==========================================
+ Coverage    69.7%   69.71%   +0.01%     
==========================================
  Files         886      886              
  Lines        7797     7800       +3     
  Branches     2285     2285              
==========================================
+ Hits         5435     5438       +3     
  Misses       2352     2352              
  Partials       10       10
Impacted Files Coverage Δ
packages/react/src/components/Tooltip/Tooltip.tsx 62.5% <100%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a786c2...f85df2c. Read the comment docs.

@vercel vercel bot temporarily deployed to staging September 3, 2019 12:52 Inactive
@vercel vercel bot requested a deployment to staging September 3, 2019 14:44 Abandoned
@vercel vercel bot temporarily deployed to staging September 3, 2019 14:44 Inactive
@lucivpav lucivpav merged commit f74a0b9 into master Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the perf/tooltip-popper branch September 3, 2019 15:00
@layershifter layershifter mentioned this pull request Sep 3, 2019
Closed
layershifter pushed a commit that referenced this pull request Sep 3, 2019
@lucivpav @layershifter
perf(Tooltip): fix Popper positioning called when unnecessary (#1882)
2b2a029 
(cherry picked from commit f74a0b9)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@layershifter layershifter layershifter approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny miroslavstastny is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
perf 🚀 ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Popper in Tooltip always executes positioning code
2 participants
@lucivpav @layershifter