-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
@@ -27,6 +27,7 @@ const unsupportedComponents = [ | |||
'Portal', | |||
'Provider', | |||
'RadioGroup', | |||
'TextArea', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem (along the lines: "A component is changing an uncontrolled input of type text to be controlled error in ReactJS") when one plays with placeholder
in the playground. So I decided to disable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be reenabled now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no longer placeholder
prop on (nor maxLength
prop), it can be enabled. But I am not sure about its value
packages/react/src/lib/accessibility/Behaviors/TextArea/textAreaBehavior.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a common test
No |
I added unit test as well as a behavior test |
This comment has been minimized.
This comment has been minimized.
There should be a text text to the textarea that has limited number of characters. (And used aria-describedby/labeledby) |
This comment has been minimized.
This comment has been minimized.
packages/react/test/specs/components/TextArea/TextArea-test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left minor comments, LGTM 👍
Let's add some dumb styles and variables (for margin: 0
, resize: vertical
) to create boilerplate under Teams theme. And add an entry to CHANGELOG.md
before merging 😼
docs/src/examples/components/TextArea/Usage/TextAreaMaxLengthExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/TextArea/Usage/TextAreaMaxLengthExample.shorthand.tsx
Outdated
Show resolved
Hide resolved
…xample.shorthand.tsx Co-Authored-By: Oleksandr Fediashov <olfedias@microsoft.com>
Implements #755
Semantic UI's TextArea for reference
Mozilla's docs on
<textarea>