This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
September 10, 2019 00:17
Codecov Report
@@ Coverage Diff @@
## master #1907 +/- ##
========================================
Coverage ? 70.5%
========================================
Files ? 884
Lines ? 7794
Branches ? 2254
========================================
Hits ? 5495
Misses ? 2289
Partials ? 10
Continue to review full report at Codecov.
|
Please measure it before merging 🤔 |
packages/react/src/themes/teams-high-contrast/components/Attachment/attachmentVariables.ts
Outdated
Show resolved
Hide resolved
… from null to undefined
master:
deep merge branch:
My interpretation of the results: there is no measurable perf impact. |
levithomason
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do deep merge of site variables and component variables.
Motivation
Let's have two themes (parent, child) merged.
To resolve styles, follow steps occur
child.siteVariables
are merged on top ofparent.siteVariables
to computesiteVariables
siteVariables
are used to computeparent.componentVariables
andchild.componentVariables
,child.componentVariables
are merged on top ofparent.componentVariables
componentVariables
are used to computeparent.styles
andchild.styles
That means that if child variables remove a variable from parent and parent styles use that variable, an exception will be thrown.