This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
refactor(Theme): move base theme styles to teams theme #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1908 +/- ##
==========================================
+ Coverage 69.99% 70.34% +0.34%
==========================================
Files 898 877 -21
Lines 7818 7738 -80
Branches 2254 2241 -13
==========================================
- Hits 5472 5443 -29
+ Misses 2336 2285 -51
Partials 10 10
Continue to review full report at Codecov.
|
mnajdova
changed the title
added 2 commits
September 11, 2019 12:13
…ms-theme' into refactor/move-base-styles-to-teams-theme
added 2 commits
September 11, 2019 17:06
…ms-theme' into refactor/move-base-styles-to-teams-theme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to remove the base theme from Stardust, as it was created in an early stage, where we didn't have more use-cases to test it against. All theme definitions (styles, variables, siteVariables etc( that were currently in the base theme, are now moved to the teams theme.
The plan is to start to work on the base theme, with adding some more designs/applications where we will test whether the definitions added in the base theme are sufficient for achieving all different cases.
For Teams theme, this is not breaking change, as all styles from base theme are now included directly in Teams theme.
Introduced PR #1941 for explicitly adding typings for teams theme as
ThemePrepared, as we no longer use mergeThemes when exporting it.