This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Accessibility): Initial accessibility attributes schema. #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshoho
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
mshoho
changed the title
mshoho
force-pushed
the
accessibility-attributes-schema
branch
from
563d55f
to
9272f79
Compare
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
+ Coverage 70.26% 70.29% +0.02%
==========================================
Files 894 894
Lines 7894 7901 +7
Branches 2286 2289 +3
==========================================
+ Hits 5547 5554 +7
Misses 2334 2334
Partials 13 13
Continue to review full report at Codecov.
|
Generated by 🚫 dangerJS |
… in the theme selector aria-labelledby.
mshoho
force-pushed
the
accessibility-attributes-schema
branch
from
9537ca4
to
e42d39e
Compare
layershifter
approved these changes
Sep 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress. The Stardust part shouldn't change, the JSON schema is about to be updated, but we can already start talking about it.
The key idea is that there is a schema which declaratively defines allowed accessibility attributes and how the accessible components can be composed. And there is a validator (which is being added to the non-production builds only) which validates the integrity at runtime and shows errors in case something is not satisfying the schema.