fix(Tree): fix focus styles #1912
Conversation
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1912 +/- ##
======================================
Coverage 70.5% 70.5%
======================================
Files 884 884
Lines 7794 7794
Branches 2278 2278
======================================
Hits 5495 5495
Misses 2289 2289
Partials 10 10
Continue to review full report at Codecov.
|
| }, | ||
| ':focus-visible': { | ||
| ...getBorderFocusStyles({ siteVariables })[':focus-visible'], | ||
| }, |
There was a problem hiding this comment.
Previous code does the same as I see
There was a problem hiding this comment.
before these changes it was not working, we are missing something.
before the removal of isFromKeyboard we had the issue that borderfocus style was applied every time. now, if you check on the stardust docsite, it won't be applied in any case (mouse or keyboard).
these changes fixes it.
There was a problem hiding this comment.
Can you please check this thing again?
It looks that this change is invalid.
silviuaavram
added
accessibility
|
Please do not accept screener tests before merging. Now, it's unclear what was really changed. |
| }, | ||
| ':focus-visible': { | ||
| ...getBorderFocusStyles({ siteVariables })[':focus-visible'], | ||
| }, |
There was a problem hiding this comment.
|
Please add CHANGELOG entry. |
* fix focus styles * add static Item to Tree * add screener tests for focus * fix selector * fix the selector better * removed unnecessary static item * change selector in screener tests * move all into a single test * change the test to allow all kb interactions * revert unneeded change * changelog (cherry picked from commit 2a9989e)
Fixes #1620
Adds screener tests for 4 cases: