This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Chat): use more accurate positioning in scrollable containers #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1929 +/- ##
=======================================
Coverage 70.47% 70.47%
=======================================
Files 884 884
Lines 7796 7796
Branches 2280 2256 -24
=======================================
Hits 5494 5494
Misses 2291 2291
Partials 11 11
Continue to review full report at Codecov.
|
layershifter
commented
Sep 13, 2019
|
|
||
| const useRangeKnob = (options: UseRangeKnobOptions) => { | ||
| const { initialValue = 3, min = 0, max = parseValue(initialValue), step = 1, ...rest } = options | ||
| const useRangeKnob = <T extends number | string>(options: UseRangeKnobOptions<T>) => { |
There was a problem hiding this comment.
Fix to properly define number/string return type
…stardust-ui/react into fix/chat-message # Conflicts: # CHANGELOG.md
jurokapsiar
approved these changes
Sep 13, 2019
layershifter
added a commit
that referenced
this pull request
Sep 13, 2019
) * fix(Chat): use more accurate positioning in scrollable containers * add example * add changelog (cherry picked from commit 98b8229)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1926.
Previously we used
unstable_pinnedonactions, this prop will only disableflipmodifier which is not correct.This PR does these changes:
flipmodifier is enabled and will moveactionsonly ontoppreventOverflowwill work only forleft/rightpositionsBefore
After