This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Dropdown): properly accept id on searchInput from Form #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviuaavram
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
silviuaavram
added
accessibility
Codecov Report
@@ Coverage Diff @@
## master #1938 +/- ##
=========================================
- Coverage 70.4% 70.4% -0.01%
=========================================
Files 892 892
Lines 7867 7870 +3
Branches 2295 2298 +3
=========================================
+ Hits 5539 5541 +2
- Misses 2315 2316 +1
Partials 13 13
Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
| @@ -25,6 +25,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm | |||
| - Fix `CreateShorthandOptions` should be typed @lucivpav ([#1886](https://github.com/stardust-ui/react/pull/1886)) | |||
| - Add `shadowLevel1Dark` in Teams themes @notandrew ([#1887](https://github.com/stardust-ui/react/pull/1887)) | |||
| - When merging themes use deep merge for site and component variables @miroslavstastny ([#1907](https://github.com/stardust-ui/react/pull/1907)) | |||
| - Fix `Dropdown` to properly accept `id` on `searchInpiut` @silviuavram ([#1938](https://github.com/stardust-ui/react/pull/1938)) | |||
There was a problem hiding this comment.
Suggested change
| - Fix `Dropdown` to properly accept `id` on `searchInpiut` @silviuavram ([#1938](https://github.com/stardust-ui/react/pull/1938)) | |
| - Fix `Dropdown` to properly accept `id` on `searchInput` @silviuavram ([#1938](https://github.com/stardust-ui/react/pull/1938)) |
Typo
docs/src/examples/components/Form/Usage/FormExampleDropdown.shorthand.tsx
Show resolved
Hide resolved
| @@ -431,6 +431,7 @@ class Dropdown extends AutoControlledComponent<WithAsProp<DropdownProps>, Dropdo | |||
| onStateChange={this.handleStateChange} | |||
| labelId={this.props['aria-labelledby']} | |||
| environment={this.context.target.defaultView} | |||
| inputId={this.props.searchInput ? this.props.searchInput['id'] : undefined} | |||
There was a problem hiding this comment.
<Dropdown searchInput={render => render('boo')} />
<Dropdown searchInput='Oops' />This thing is pretty fragile. Do we have other options?
There was a problem hiding this comment.
you are right, I need to add another check. this will only work if searchInput is an object.
jurokapsiar
approved these changes
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass
searchInput.idtoDownshift'spropinputId.fix the Form + Dropdown example to make the searcInput focusable on label click.