This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Popper): fix comparison for scrollParent
#1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
…/github.com/stardust-ui/react into fix/popper-compare-with-body
Codecov Report
@@ Coverage Diff @@
## master #1959 +/- ##
==========================================
+ Coverage 70.26% 70.27% +<.01%
==========================================
Files 893 893
Lines 7891 7892 +1
Branches 2309 2309
==========================================
+ Hits 5545 5546 +1
Misses 2333 2333
Partials 13 13
Continue to review full report at Codecov.
|
jurokapsiar
approved these changes
Sep 23, 2019
layershifter
added a commit
that referenced
this pull request
Sep 26, 2019
(cherry picked from commit 15db9b8)
Merged
layershifter
added a commit
that referenced
this pull request
Oct 1, 2019
* fix(Popper): fix comparison for `scrollParent` * add changelog (cherry picked from commit 15db9b8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924
The previous check was always false positive when
Popperwas rendered in another document. This PR fixes it.