This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(ToolbarMenuItem): add menu prop #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
miroslavstastny
as code owners
added 2 commits
October 1, 2019 08:47
-added example
-fixed typings
mnajdova
commented
Oct 1, 2019
packages/react/src/themes/teams/components/Toolbar/toolbarMenuItemStyles.ts
Show resolved
Hide resolved
mnajdova
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1984 +/- ##
==========================================
- Coverage 70.38% 69.86% -0.52%
==========================================
Files 895 896 +1
Lines 7890 7963 +73
Branches 2311 2309 -2
==========================================
+ Hits 5553 5563 +10
- Misses 2324 2387 +63
Partials 13 13
Continue to review full report at Codecov.
|
docs/src/examples/components/Toolbar/Content/ToolbarExampleMenuWithSubmenu.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/Toolbar/Content/ToolbarExampleMenuWithSubmenu.shorthand.tsx
Outdated
Show resolved
Hide resolved
|
We also need some E2E to be sure that this feature will not break. |
added 8 commits
October 21, 2019 18:06
# Conflicts: # CHANGELOG.md
-fixed typing errors
…st-ui/react into feat/toolbar-menu-submenu
…st-ui/react into feat/toolbar-menu-submenu
…oft/fluent-ui-react into feat/toolbar-menu-submenu # Conflicts: # build/gulp/tasks/test-circulars/config.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added menu prop on the
ToolbarMenuItemfor allowing creating submenus in the Toolbar. It behaves the same way as theMenu's submenus - the implementation is a bit different, because we need to support popups inside theToolbarMenuItemtoo.