Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(Menu): Update styling for *primary underlined* to match Teams style #20

Merged
merged 5 commits into from
Aug 6, 2018

Conversation

miroslavstastny
Copy link
Member

Menu underlined primary

Style of the underlined primary menu was updated to match Teams look and feel.

Stardust Before:

image

Stardust After:

image

Real Teams:

image

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

The main change is that previously the whole menu item was underlined but now only the caption is underlined.

I was thinking about implementing it conditionally using fitted prop but I do not see any use for the old look in Teams. For that reason I consider it the only look for underlined menu in Teams theme.

Clone of stardust-ui/react-old#107

@codecov
Copy link

codecov bot commented Jul 27, 2018

Codecov Report

Merging #20 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   87.45%   87.37%   -0.08%     
==========================================
  Files          74       74              
  Lines        1124     1125       +1     
  Branches      210      200      -10     
==========================================
  Hits          983      983              
- Misses        137      138       +1     
  Partials        4        4
Impacted Files Coverage Δ
src/components/Menu/menuVariables.ts 100% <ø> (ø) ⬆️
src/components/Menu/menuRules.ts 100% <ø> (ø) ⬆️
src/components/Menu/menuItemRules.ts 83.87% <0%> (-2.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cb8bb9...89d6c3e. Read the comment docs.

@miroslavstastny miroslavstastny changed the title feat(Menu): Update styling for *primary underlined* to match Teams style #107 feat(Menu): Update styling for *primary underlined* to match Teams style Jul 27, 2018
@miroslavstastny miroslavstastny merged commit 7b43139 into master Aug 6, 2018
@miroslavstastny miroslavstastny deleted the feat/menu-update-teams-underlined-styling branch August 6, 2018 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants