This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat(ListItem,Button,ToolbarItem,ToolbarMenu): Adding/fixing universal focus indicator #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correcting toolbar focus (remove hover treatment)
…at/add-focus-toolbar-icons
bcalvery
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
October 4, 2019 17:21
…at/add-focus-toolbar-icons
…at/add-focus-toolbar-icons
…into feat/add-focus-toolbar-icons
…into feat/add-focus-toolbar-icons
…into feat/add-focus-toolbar-icons
bcalvery
changed the title
feat(ListItem,Button,ToolbarItem,ToolbarMenu): Adding/fixing univeral focus indicator
feat(ListItem,Button,ToolbarItem,ToolbarMenu): Adding/fixing universal focus indicator
Oct 25, 2019
…into feat/add-focus-toolbar-icons
codepretty
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keyboarded around a few components and looks good from what I can tell! thanks Brian!!
codepretty
reviewed
Oct 29, 2019
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/Button/buttonVariables.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/List/listItemStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/Toolbar/toolbarCustomItemStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/Toolbar/toolbarCustomItemStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/Toolbar/toolbarItemStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/Toolbar/toolbarItemStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
packages/react/src/themes/teams/components/Toolbar/toolbarMenuItemStyles.ts
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating ListItem, Button, ToolbarItem, ToolbarMenuItem to use the common "getBorderFocusStyles" component to indicate keyboard focus.
Also incorporated theme changes for button - fixing issues reported by design.
Note: Keyboard focus is now a distinctly separate treatment from hover.
ListItem:
Selected item at bottom of each list, keyboard focused item at top.
Before:
After:
Button:
Issue with border was in the wrong position (it should be outboard of main button border)
Idle state on left, keyboard focus state on right.
Before:
After:
Before:
After:
Note style of circular button is changed to behave like normal button.
Also updated buttonVariables to use colorScheme variables.
ToolbarItem
Before:
After:
ToolbarMenuItem:
Before:
After: