Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

fix(attachment): Removing opacity from subtext, updating colors to match Teams theme #2012

Merged
merged 13 commits into from
Oct 31, 2019
Merged

fix(attachment): Removing opacity from subtext, updating colors to match Teams theme #2012

merged 13 commits into from
Oct 31, 2019

Conversation

notandrew
Copy link
Member

before:
image

after:
image

@codecov
Copy link

codecov bot commented Oct 4, 2019 •
edited

Codecov Report

Merging #2012 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2012   +/-   ##
=======================================
  Coverage   76.71%   76.71%           
=======================================
  Files         160      160           
  Lines        5493     5493           
  Branches     1604     1604           
=======================================
  Hits         4214     4214           
  Misses       1266     1266           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edca816...a36c0b7. Read the comment docs.

@notandrew notandrew changed the title updating attachment styles fix(attachment): Removing opacity from subtext, updating colors to match Teams theme Oct 29, 2019
kolaps33
kolaps33 reviewed Oct 31, 2019
View reviewed changes
Copy link
Collaborator

@kolaps33 kolaps33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me :)
image

miroslavstastny
miroslavstastny approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@miroslavstastny miroslavstastny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review and approve screener changes before merge.

@notandrew notandrew merged commit 7d5483d into master Oct 31, 2019
@notandrew notandrew deleted the fix/attachment-color branch October 31, 2019 18:24
@jurokapsiar jurokapsiar mentioned this pull request Nov 7, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaps33 kolaps33 kolaps33 left review comments

@miroslavstastny miroslavstastny miroslavstastny approved these changes

@dvdzkwsk dvdzkwsk Awaiting requested review from dvdzkwsk

@kuzhelov kuzhelov Awaiting requested review from kuzhelov

@layershifter layershifter Awaiting requested review from layershifter layershifter is a code owner

@levithomason levithomason Awaiting requested review from levithomason levithomason is a code owner

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
💅 styling issue teams theme vsts Paired with ticket in vsts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@notandrew @miroslavstastny @kolaps33