This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(docs): RTL and Theme it buttons #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
miroslavstastny
commented
Oct 9, 2019
| @@ -37,7 +36,7 @@ const ComponentExampleVariables: React.FunctionComponent< | |||
| const { onChange, overriddenVariables, usedVariables } = props | |||
|
|
|||
| const { theme } = React.useContext<ProviderContextPrepared>(ThemeContext) | |||
| const [hideUnused, setHideUnused] = React.useState(true) | |||
| const [hideUnused] = React.useState(true) | |||
There was a problem hiding this comment.
Is this just temporary and we want to invest into finding a way hot to do it or should we remove this completely? 🤔
There was a problem hiding this comment.
Let's hide this temporary and see what we can do later
Codecov Report
@@ Coverage Diff @@
## master #2020 +/- ##
======================================
Coverage 75.8% 75.8%
======================================
Files 160 160
Lines 5572 5572
Branches 1631 1631
======================================
Hits 4224 4224
Misses 1334 1334
Partials 14 14
Continue to review full report at Codecov.
|
| @@ -223,6 +223,7 @@ const renderComponent = <P extends {}>( | |||
| const direction = rtl ? 'rtl' : 'ltr' | |||
| const felaParam = { | |||
| theme: { direction }, | |||
| displayName, // does not affect styles, only used by useEnhancedRenderer | |||
There was a problem hiding this comment.
Suggested change
| displayName, // does not affect styles, only used by useEnhancedRenderer | |
| displayName, // does not affect styles, only used by useEnhancedRenderer in doc site |
layershifter
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1997
Hide unused variables still does not work as it would require to pass unresolved styles and component variables to Fela and we removed that in #1957.
Performance wins over docs => Hide unused variables (temporarily) removed from docs.