This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix: teams theme font sizes #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
requested review from
dvdzkwsk,
kuzhelov,
miroslavstastny and
mnajdova
as code owners
levithomason
force-pushed
the
fix/teams-font-sizes
branch
from
0ca5e3d
to
7a51b52
Compare
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 50 50
Lines 836 836
Branches 130 130
=======================================
Hits 746 746
Misses 86 86
Partials 4 4Continue to review full report at Codecov.
|
mnajdova
approved these changes
Sep 7, 2018
kuzhelov
approved these changes
Sep 7, 2018
|
Hey guys, for safety let's let authors call for reviews and merge their own PRs. I was still working on this PR and it was failing screener for valid reasons. Merge themes is not respecting static styles nor font faces. The docs are not using the correct font faces or static styles after this merge. I was adding fixes for that before merge / review. I will push the fixes in a separate PR to keep things moving forward. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Teams theme uses an html font size of 10px and scales the body by
1.4remto achieve a 14px body size.This PR updates the html and body font size values in Teams' theme. It also scales the doc site Provider values to maintain Semantic UI's 14px html font size need.