This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Chat): add unstable_overflow for Chat.Message #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
feat/chat-overflow
branch
from
767fd2b
to
f3f0855
Compare
layershifter
force-pushed
the
feat/chat-overflow
branch
from
f3f0855
to
f1a157f
Compare
layershifter
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
miroslavstastny
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
unstable_overflowprop to allow more flexible positioning ofactionMenuslot. Currently whenChatMessageis inside of scrollable containeractionMenuwill be clipped.unstable_overflow={false}by default & current behaviorunstable_overflow={true}Why do not enable this by default?
ChatMessageinside of scrollable container (overflow: hidden)actionMenuit's required to usefixedmode which can potentially affect performance and introduce other potential issuesMy proposal is to go with a separate prop with
unstable_prefix for now, once we will see that this solution is correct or we will find other one we can decide.