Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat: Add Status as a separate component #208

Merged
merged 42 commits into from
Sep 12, 2018

Conversation

musingh1
Copy link
Contributor

@musingh1 musingh1 commented Sep 7, 2018

Status

A status graphically represents someone's or something's state. Updated the Avatar component to consume this

TODO

  • Conformance test
  • Minimal doc site example
  • Stardust base theme
  • Teams Light theme
  • Teams Dark theme
  • Teams Contrast theme
  • Confirm RTL usage
  • W3 accessibility check
  • Stardust accessibility check
  • Update glossary props table
  • Update the CHANGELOG.md

API Proposal

state

Common states are included.

image

color, icon

The color and icon props are used for creating custom states.

image
image
image

Usage in Avatar

The alignment and size has been fixed.

image

The state prop is used to denote the current availability of the user.

<Status state="success" icon="check" />
<span class="ui-status y z ab ac dj ae af ag">
    <span class="ui-icon ah aj w ai ak al am an h ao ap aq ar as at au dk ax ay az ba q bb dp bd" aria-hidden="true">
    </span>
</span>

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2578702). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #208   +/-   ##
=========================================
  Coverage          ?   91.53%           
=========================================
  Files             ?       61           
  Lines             ?     1028           
  Branches          ?      136           
=========================================
  Hits              ?      941           
  Misses            ?       83           
  Partials          ?        4
Impacted Files Coverage Δ
src/index.ts 100% <100%> (ø)
src/components/Avatar/Avatar.tsx 96.66% <100%> (ø)
src/components/Status/index.ts 100% <100%> (ø)
src/components/Status/Status.tsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2578702...110ebca. Read the comment docs.

@levithomason levithomason changed the title feat: Add StatusIndicator as a separate component feat: Add Status as a separate component Sep 12, 2018
Copy link
Member

@levithomason levithomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for a first take. We will likely iterate a bit on this moving forward, but we have what we need here to get a good start. Thanks!

👍

@levithomason levithomason merged commit e777e3b into master Sep 12, 2018
@levithomason levithomason deleted the feature/mukul/status-indicator branch September 12, 2018 06:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants