This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 55
feat: Add Status as a separate component #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resence-component
musingh1
requested review from
dvdzkwsk,
kuzhelov and
levithomason
as code owners
September 7, 2018 23:09
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=========================================
Coverage ? 91.53%
=========================================
Files ? 61
Lines ? 1028
Branches ? 136
=========================================
Hits ? 941
Misses ? 83
Partials ? 4
Continue to review full report at Codecov.
|
levithomason
changed the title
feat: Add StatusIndicator as a separate component
feat: Add Status as a separate component
Sep 12, 2018
levithomason
force-pushed
the
feature/mukul/status-indicator
branch
from
September 12, 2018 05:35
7e5856b
to
f3a687f
Compare
levithomason
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for a first take. We will likely iterate a bit on this moving forward, but we have what we need here to get a good start. Thanks!
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
A status graphically represents someone's or something's state. Updated the Avatar component to consume this
TODO
API Proposal
state
Common states are included.
color, icon
The color and icon props are used for creating custom states.
Usage in Avatar
The alignment and size has been fixed.
The state prop is used to denote the current availability of the user.