This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(Divider): misusage of the variables for the default and secondary type #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 14, 2018 17:27
-renamed default to just color and backgroundColor props
mnajdova
requested review from
dvdzkwsk,
kuzhelov,
levithomason and
miroslavstastny
as code owners
notandrew
approved these changes
Sep 14, 2018
kuzhelov
approved these changes
Sep 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Divider
The usage of the typeSecondaryXXX and defaultXXX variables was wrong, which produces bug in the usage of the variables.
Reproduce bug
Use the divider in the following manner:
Expected behavior
The color of the Divider should be changed to black
Actual behavior
The color is not changed as this variables is used for the default type of the Divider, not the secondary.
Addition
Also the defaultColor, and defaultBackgroundColor are changed to color and backgroundColor.