This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
docs(chat-pane): chat-pane prototype #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmdalex
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
bmdalex
force-pushed
the
docs/chat-pane-prototype
branch
9 times, most recently
from
71ba1bf
to
029ffac
Compare
bmdalex
force-pushed
the
docs/chat-pane-prototype
branch
from
029ffac
to
6b683a9
Compare
alinais
reviewed
Sep 17, 2018
|
I guess we have to polish a bit the UI, so that the buttons in the header would look more like in the real life, not quite like this:
|
|
@alinais well this is a limitation we currently have in stardust; there's not much I can do to make them look better without improving current set of components we use here (especially icons). Here I see issues with:
But I think most of these are taken care of in different PRs and will be reflected in the prototype later. |
sophieH29
reviewed
Sep 17, 2018
…totype # Conflicts: # CHANGELOG.md # docs/src/routes.tsx
# Conflicts: # CHANGELOG.md # src/components/Chat/ChatMessage.tsx # src/themes/teams/components/Chat/chatStyles.ts # src/themes/teams/components/Chat/chatVariables.ts
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 62 62
Lines 1167 1167
Branches 150 150
=======================================
Hits 1046 1046
Misses 119 119
Partials 2 2
Continue to review full report at Codecov.
|
…cs/chat-pane-prototype
# Conflicts: # src/components/Chat/Chat.tsx # src/components/Chat/index.ts
…cs/chat-pane-prototype
…cs/chat-pane-prototype
…cs/chat-pane-prototype
mnajdova
reviewed
Oct 3, 2018
mnajdova
reviewed
Oct 3, 2018
mnajdova
reviewed
Oct 3, 2018
mnajdova
reviewed
Oct 3, 2018
mnajdova
reviewed
Oct 3, 2018
mnajdova
approved these changes
Oct 3, 2018
mnajdova
reviewed
Oct 3, 2018
…cs/chat-pane-prototype
…cs/chat-pane-prototype
mnajdova
reviewed
Oct 3, 2018
mnajdova
reviewed
Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat pane prototype
This PR contains a
Chat paneprototype that comes under the newPrototypessection in the docs experience. This is not available in prod so users need to actually build the project to see the prototypes.