docs: more theming examples #252
Conversation
alinais
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
======================================
Coverage 91.8% 91.8%
======================================
Files 63 63
Lines 1171 1171
Branches 173 173
======================================
Hits 1075 1075
Misses 92 92
Partials 4 4Continue to review full report at Codecov.
|
| </p> | ||
|
|
||
| <ol> | ||
| <li> |
There was a problem hiding this comment.
seems to be a good place to paste picture @hughreeling was talking about. Probably, for now we could use ul for enumerating these options
docs/src/views/ThemingExamples.tsx
Outdated
|
|
||
| <Header as="h3" content="Nesting Providers" /> | ||
| <p> | ||
| If you need to customize a bigger part of the theme, you can nest the second provider and |
There was a problem hiding this comment.
probably, it would be good to mentioning common use cases where one will need to preserver most of theming aspects, but at the same time achieve one or more of the following
- tweak some specific styling aspects of existing theme - so to speak, build theme on top of existing one
- introduce theme changes that will be applied to specific components' subtree only
This will immediately provide reader with an idea whether this section is something she is looking for
docs/src/views/ThemingExamples.tsx
Outdated
|
|
||
| export default () => ( | ||
| <DocPage title="Theming Examples"> | ||
| <Header as="h2" content="Theming needs" /> |
There was a problem hiding this comment.
needs doesn't seem right here. Theming approaches? Theming mechanisms? Theming techniques?
docs/src/views/ThemingExamples.tsx
Outdated
| A Theme defines default values and functions to generate variables that will eventually be | ||
| used to generate styles for individual components. | ||
| </p> | ||
| <p>Stardust is intentional in supporting three levels of theming needs:</p> |
There was a problem hiding this comment.
There seem to be four...
This PR adds more examples for the Theming guide.