-
Notifications
You must be signed in to change notification settings - Fork 55
feat(menu): add menu item focus styles #286
Conversation
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 89.9% 89.62% -0.29%
==========================================
Files 62 62
Lines 1159 1166 +7
Branches 150 173 +23
==========================================
+ Hits 1042 1045 +3
- Misses 115 119 +4
Partials 2 2
Continue to review full report at Codecov.
|
63d86af
to
7dd3d84
Compare
ready for review: |
7dd3d84
to
c2e3104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, not sure about removing focus ring for all Menu types.
c2e3104
to
f3bc6f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment for consideration, other then that, looks good by me. Please create an issue for the isFromKeyboard service explaining the problem you encountered.
f3bc6f7
to
e543111
Compare
Menu
This PR main purposes:
TODO
Description
type="primary"
All primary (
type="primary"
) menus get updated background foractive
,focus
andhover
states.underlined
Underlined menus get new styles for
active
,focus
andhover
states.iconOnly
Menus with only icons as item get new styles for
active
,focus
andhover
states.1. regular:
2. inverted (by tweeking variables):
3. vertical (with
vertical
prop):